Migrate random to pyproject.toml from setup.py#62
Conversation
057f53c to
091f047
Compare
|
@vtavana did you see this at all with |
pyproject toml from setup.pypyproject.toml from setup.py
9abf583 to
b9544d8
Compare
|
@ekomarova |
|
Thanks, @ndgrigorian! As soon as there is a tag that includes these changes, I can rebuild mkl_random to include this in the internal recipe |
vtavana
left a comment
There was a problem hiding this comment.
Thank you, @ndgrigorian!
bca1fd8 to
e7beee2
Compare
12a73eb to
fe5dfe1
Compare
fe5dfe1 to
af95b70
Compare
numpy_build_version->numpy_version Test with same version of NumPy as build Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
b1b51c5 to
5b57e0f
Compare
5b57e0f to
1f4ca6b
Compare
|
@antonwolfy |
901e59b to
afa3a09
Compare
afa3a09 to
dc5c0c5
Compare
|
@antonwolfy @vtavana |
|
The expected checks are present because of a change in the naming of the workflow in https://github.com/IntelPython/mkl_random/pull/65/files You can remove them from the required list in the setting (and add the equivalent one with the new name). I do not have access to setting in this repo. Settings > Rules > Rulesets > Repository rulesets > Require status checks to pass > show additional settings |
Good call, this was the issue, thanks |
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @ndgrigorian
This PR migrates
mkl_randomtopyproject.tomlfromsetup.pyAlso adjusts build system, removing
mkl-serviceas a test requirement (it was previously added as part of a work-around, which was removed) and moves to usepython -m pip installin build scripts instead of callingsetup.pyand updates min NumPy version